-
Notifications
You must be signed in to change notification settings - Fork 0
+2,094
−1,625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration in the login, queue_list and queue resources
…d of just the api
Closed
Working on this. |
Initial review thoughts: Much more than just a restructuring of the package went into this PR
I've yet to confirm functionality but the code itself is hard to follow with mountains of nested conditionals and spaghetti imports. Significant refactoring will be needed for the code to be acceptable. In addition to this, the various steps of the API need to be consolidated rather than repeated in various sections. Comments/doc blocks also need to be updated. The next steps are:
There may be more. This might need to be rebranched and approached more systematically. |
Closing in favor of refactor-to-module-layout branch. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of code to increase modularity. Also adds config file and command line argument support for interacting with the static module.
Closes #20